decimal values passed as string now work (again) #316
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a 100% sure that this is a fix for Oscar. I suggest this
change to be included because of the following reasons:
would return an empty string '' whenever an invalid type was
passed in. It think it makes sense to be backwards compatible.
string. This means that whenever the currency filter is applied
it has to be ensured that it is not an empty value. Otherwise
the filter raises an exception.
This might cause additional issues due to the way the Djangoo
templating system usually fails silently.
Please take a look at the suggested code in the commit and let me
know if this is a feasible addition/extension.