Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inflexible product url #3513

Merged
merged 1 commit into from Sep 25, 2020
Merged

Fix inflexible product url #3513

merged 1 commit into from Sep 25, 2020

Conversation

MaziyarMK
Copy link
Contributor

This ensures updating the get_absolute_url in Product model won’t cause issues in dashboard reviews list section.

This ensures updating the get_absolute_url in Product model won’t cause issues in dashboard reviews list section.
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #3513 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3513   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files         289      289           
  Lines       15571    15571           
=======================================
  Hits        13261    13261           
  Misses       2310     2310           

Copy link
Member

@solarissmoke solarissmoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@solarissmoke solarissmoke merged commit 744e144 into django-oscar:master Sep 25, 2020
@MaziyarMK MaziyarMK deleted the patch-1 branch September 25, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants