[FEAT] Absolute discount benefit applied on each product #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4168 +/- ##
==========================================
+ Coverage 87.50% 87.53% +0.02%
==========================================
Files 290 290
Lines 15912 15946 +34
==========================================
+ Hits 13924 13958 +34
Misses 1988 1988
|
specialunderwear
requested changes
Sep 15, 2023
viggo-devries
previously requested changes
Sep 15, 2023
specialunderwear
requested changes
Sep 15, 2023
specialunderwear
requested changes
Sep 15, 2023
specialunderwear
approved these changes
Sep 15, 2023
specialunderwear
deleted the
samar/fixed-discount-per-product-benefit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an absolute discount benefit that is added to each of the applicable lines. The value in the benefit defines the maximum discount amount regardless of the product quantity. If price * quantity is less than the value than the product is free.