Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Offer's slug doesn't support unicode #4172

Merged
merged 2 commits into from
Sep 26, 2023
Merged

[FIX] Offer's slug doesn't support unicode #4172

merged 2 commits into from
Sep 26, 2023

Conversation

samar-hassan
Copy link
Contributor

Resolves #4152

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #4172 (3832e3d) into master (39e7c8d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4172      +/-   ##
==========================================
+ Coverage   87.53%   87.61%   +0.08%     
==========================================
  Files         290      290              
  Lines       15946    15946              
==========================================
+ Hits        13958    13971      +13     
+ Misses       1988     1975      -13
Files Changed Coverage Δ
src/oscar/apps/catalogue/apps.py 100.00% <ø> (ø)
src/oscar/apps/dashboard/catalogue/apps.py 100.00% <100.00%> (ø)
src/oscar/apps/dashboard/communications/apps.py 100.00% <100.00%> (ø)
src/oscar/apps/offer/apps.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

specialunderwear
specialunderwear requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@specialunderwear specialunderwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small test for each url that demonstrates unicode slugs are now handled properly?

@specialunderwear specialunderwear merged commit 1c25682 into master Sep 26, 2023
23 checks passed
@specialunderwear specialunderwear deleted the samar/slug-unicode-support branch September 26, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@specialunderwear specialunderwear specialunderwear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer's slug doesn't support unicode
2 participants
@samar-hassan @specialunderwear