Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootstrap responsive image class #4192

Merged

Conversation

jamesp9
Copy link
Contributor

@jamesp9 jamesp9 commented Oct 30, 2023

Found when viewing product images on the mobile. That the image wasn't centered properly and stretched off to the right a little. Setting Bootstrap's class for responsive images seems to do the trick.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #4192 (83dda11) into master (d791838) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4192      +/-   ##
==========================================
- Coverage   87.76%   87.67%   -0.10%     
==========================================
  Files         290      290              
  Lines       16047    15864     -183     
==========================================
- Hits        14084    13909     -175     
+ Misses       1963     1955       -8     

see 183 files with indirect coverage changes

Copy link
Member

@specialunderwear specialunderwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@specialunderwear specialunderwear merged commit b62bbb8 into django-oscar:master Oct 31, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants