django.utils.timezone.utc was removed in Django 5.0 #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4231 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 291 291
Lines 16145 16145
=======================================
Hits 14182 14182
Misses 1963 1963 |
viggo-devries
requested changes
Jan 26, 2024
| @@ -1,4 +1,4 @@ | |||
| from datetime import timedelta | |||
| from datetime import timedelta, timezone as datetime_timezone | |||
There was a problem hiding this comment.
please do
from datetime.timezone import utc
There was a problem hiding this comment.
Does not work. datetime is wired / weird that way.
% python3.12
Python 3.12.1 (main, Dec 7 2023, 20:45:44) [Clang 15.0.0 (clang-1500.1.0.2.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from datetime.timezone import utc
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'datetime.timezone'; 'datetime' is not a package
There was a problem hiding this comment.
okay whatever this is in tests anyway so it does not really matter.
cclauss
force-pushed
the
django.utils.timezone.utc-removed-in-Django-5.0
branch
from
d406043
to
10a4d29
Compare
cclauss
force-pushed
the
django.utils.timezone.utc-removed-in-Django-5.0
branch
from
548389c
to
b6e6bd3
Compare
viggo-devries
approved these changes
Feb 15, 2024
| @@ -1,4 +1,4 @@ | |||
| from datetime import timedelta | |||
| from datetime import timedelta, timezone as datetime_timezone | |||
There was a problem hiding this comment.
okay whatever this is in tests anyway so it does not really matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.djangoproject.com/en/stable/releases/5.0/#features-removed-in-5-0
https://docs.djangoproject.com/en/stable/releases/4.1/#id2