Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTP_TWILIO_MESSAGING_SERVICE_SID setting #9

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

mkgs
Copy link
Contributor

@mkgs mkgs commented Jul 20, 2023

Proposed OTP_TWILIO_MESSAGING_SERVICE_SID setting that, when provided, sends from the designated Twilio messaging service and lets Twilio pick the sender SMS number instead of providing a single number.

Twilio docs

We recently ran into an issue with sending OTP codes to UK (+44) numbers with our toll-free US number - UK providers have blocked SMS messages from US long code numbers. It looks like the way around this is to send from a messaging service with numbers from multiple regions.

@psagers
Copy link
Member

psagers commented Jul 20, 2023

Definitely. The setting just needs documentation.

@mkgs
Copy link
Contributor Author

mkgs commented Jul 20, 2023

@psagers cool I'll commit doc changes when able

@mkgs
Copy link
Contributor Author

mkgs commented Jul 20, 2023

@psagers added a section in the docs and tried to keep the same formatting style

@psagers psagers merged commit 17fd545 into django-otp:master Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants