-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cache.py bug and test #52
Conversation
Related to issue django-parler#49 Removed the "long" from the format of master_id, so now can support not integer values for primary_keys.
I have detected this issue in my proyect also, PK as integers is a very restrictive condition. Thanks |
I use string pks in most of my classes so this fix is needed |
I strongly support the change. |
Thanks @cdelafuen for your PR. I sent an email weeks ago to fix this issue because is critical in my project. Please merge it. |
You'll probably need to add tests on this, to be sure that everything is good ! |
I have the same problem in one of my projects. I do not understand why to cast the primary key to a long type. |
This solved the issue in our project. Thanks! |
Added test to cover this bug. |
Related to issue #49
Removed the "long" from the format of master_id, so now can support not integer values for primary_keys.