Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cache.py bug and test #52

Merged
merged 2 commits into from
Dec 15, 2014
Merged

Conversation

cdelafuen
Copy link
Contributor

Related to issue #49

Removed the "long" from the format of master_id, so now can support not integer values for primary_keys.

Related to issue django-parler#49

Removed the "long" from the format of master_id, so now can support not integer values for primary_keys.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling de3bb0f on cdelafuen:patch-1 into 27949ed on edoburu:master.

@mzaforas
Copy link

mzaforas commented Dec 3, 2014

I have detected this issue in my proyect also, PK as integers is a very restrictive condition.
I support the change!

Thanks

@IvanAlegre
Copy link

I use string pks in most of my classes so this fix is needed

@aleonsan
Copy link

aleonsan commented Dec 3, 2014

I strongly support the change.
We cant assume that master pk should be casted as a specific type. LGTM

@redondofelix
Copy link

Thanks @cdelafuen for your PR. I sent an email weeks ago to fix this issue because is critical in my project. Please merge it.

@NotSqrt
Copy link
Collaborator

NotSqrt commented Dec 3, 2014

You'll probably need to add tests on this, to be sure that everything is good !

@mdogo
Copy link

mdogo commented Dec 3, 2014

I have the same problem in one of my projects. I do not understand why to cast the primary key to a long type.

@Hispar
Copy link

Hispar commented Dec 3, 2014

This solved the issue in our project. Thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 9ed8253 on cdelafuen:patch-1 into 27949ed on edoburu:master.

@cdelafuen
Copy link
Contributor Author

Added test to cover this bug.

@cdelafuen cdelafuen changed the title Update cache.py Fixed cache.py bug and test Dec 9, 2014
vdboor added a commit that referenced this pull request Dec 15, 2014
Fixed cache.py bug and test
@vdboor vdboor merged commit ab76f3a into django-parler:master Dec 15, 2014
vdboor added a commit that referenced this pull request Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants