Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded backwards compatibility support #42

Merged
merged 2 commits into from Jul 7, 2017
Merged

Remove unneeded backwards compatibility support #42

merged 2 commits into from Jul 7, 2017

Conversation

edmorley
Copy link
Contributor

  • Remove DEFAULT_TIMEOUT backwards compatibility support. (Since the lowest Django version supported is 1.8, and DEFAULT_TIMEOUTwas added in Django 1.6: django/django@89955cc)
  • Remove backwards compatibility support for pylibmc < 1.3.0. (Since the minimum pylibmc version required by setup.py is 1.4.1.)

Since the lowest Django version supported is 1.8, and `DEFAULT_TIMEOUT`
was added in Django 1.6:
django/django@89955cc
Since the minimum pylibmc version required by setup.py is 1.4.1.
@edmorley
Copy link
Contributor Author

edmorley commented Jul 6, 2017

Rebased on master, @jwhitlock I don't suppose you could take a look? :-)

@jwhitlock
Copy link
Member

I am tempted to wait a whole year, but...

Looks good. Thanks @edmorley!

@jwhitlock jwhitlock merged commit bdfbf18 into django-pylibmc:master Jul 7, 2017
@edmorley edmorley deleted the cleanup-backwards-compat branch July 7, 2017 08:51
@edmorley
Copy link
Contributor Author

edmorley commented Jul 7, 2017

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants