Move class to widget #275
Merged
Move class to widget #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add a form-control class to the div of a form field. With a hard coded class in the templates, this results in two class attributes which is not allowed. This change moves the class to the widget. This allows the widget to do all the class inserting and avoid creating duplicate class attributes on the div.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #208
The bootstrap_form tag in the popular django-bootstrap4 package will add a form-control class to the div of a form field. With a hard coded class in the templates, this results in two class attributes which is not allowed.
This change moves the class to the widget. This allows the widget to do all the class inserting and avoid creating duplicate class attributes on the div.