Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #280: Mark ReCaptchaV3 as a hidden field #294

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

matthiask
Copy link
Contributor

@matthiask matthiask commented Nov 23, 2022

This skips outputting a label and improves behavior around error messages.

I omitted the changelog entry because it would conflict with #293

Copy link
Contributor

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! will await others for feedback and double check later

@andre-dasilva
Copy link

This would be great. Instead of overriding is_hidden (which is a property),
it might be better to set the input_type = 'hidden'

@Stormheg
Copy link
Contributor

@matthiask for your information, I've pushed to your branch and made the suggested change to set input_type="hidden" + added a test to check the label is omitted.

@Stormheg Stormheg merged commit 5dd9931 into django-recaptcha:main Sep 29, 2023
7 checks passed
@matthiask matthiask deleted the v3-hidden branch September 29, 2023 13:21
@matthiask
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants