moved recaptcha execute into event listener function on form submit #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When will this pull request be merged? Any Aprox date? |
JulianMartos
approved these changes
Dec 27, 2022
JulianMartos
approved these changes
Dec 28, 2022
Andrew-Chen-Wang
approved these changes
Feb 14, 2023
|
thanks! |
This was referenced Dec 14, 2023
|
FWIW; this is now causing issues for people with custom form submit handlers. See #348. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the execute to on form submit action. This should fix invalid captcha problems if user takes more than 2 minutes to fill out forms. Note that google recommends this also...
Note: reCAPTCHA tokens expire after two minutes. If you're protecting an action with reCAPTCHA, make sure to call execute when the user takes the action rather than on page load.