Add Django 4.2 and Python 3.11 testing #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Django version from Github CI matrix and only create jobs for every supported Python. **Reasoning:** not all Django versions are compatible with every Python. Having to update and/or exclude certain combinations from the Github matrix is a maintenance overhead. Failures for a specific Django version can be reviewed by checking the CI logs. - Add Django 4.2 - Drop Django 4.0 - Drop Django 2.2 - Add Python 3.11 - Drop Python 3.7
Make it a separate job not run by default when executing tox. The in-development version of Django can be unstable and cause failures that are not relevant when contributing.
Reword existing entries for consistency with older entries.
|
@Andrew-Chen-Wang as most active co-maintainer, could I kindly ask you to review this PR? Thank you! |
Andrew-Chen-Wang
approved these changes
Sep 14, 2023
|
Not sure why pre-commit is failing. But I also think that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Python 3.7, Django 2.2 and 4.0
Also reworked the Github actions CI matrix a bit with the intend to improve maintainability. See commit message for reasoning.
Most controversial change is not including the compatibility check with the current in-development Django. There is not guarantee on how stable it is and I'd rather not see it included by default in our testing matrix. I feel like CI errors that are caused by a bug in Django are something we would want to avoid, not something to ignore when it occurs.
If there is interest, I'd suggest we set up a separate job that periodically runs the tests against the in-development Django.