Real remote IP shown while using proxy (e.g. nginx/gunicorn configuration)

[gidantribal]

#54

[andhieka]

This is still open after 2 years... Is there a possibility of merging this? I can help with anything necessary. This is a good library.

[andhieka]

self.ip = get_real_ip(request) or ''

Maybe we should read the REQUEST_IP_DUMMY setting instead of using empty string (''). As pointed out in another issue #72, an empty string causes PostgreSQL to throw an error because empty string is not a valid ip address.

[lukeburden]

+1 for using ipware for reliably extracting the IP correctly across a more diverse range of deployment scenarios.

[ssuchanowski]

is there any plan of merging this?

[satadev]

also this should be applied to middleware.py, else the REQUEST_IGNORE_IP param will not function.

[mrtaalebi]

Why they don't merge this?

[timjonez]

Hey! I literally changed a couple lines and got this working. Is anyone actually maintaining this? This problem should be fixed 6 years ago.

[hvitis]

Wow. I just wasted a couple of hours just to get to the core of this.
Even opened a topic here:
#251

My fix for anybody who will need it:

import re
...

def is_valid_ip(ip):
    m = re.match(r"^(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})$", ip)
    return bool(m) and all(map(lambda n: 0 <= int(n) <= 255, m.groups()))

class Request(models.Model):
    ...

    def from_http_request(self, request, response=None, commit=True):
        ...
        ip_addr = [
            request.META.get('HTTP_REMOTE_ADDR', None),  
            request.META.get('HTTP_X_REAL_IP', None),
            request.META.get('HTTP_X_FORWARDED_FOR', None),
            request.META.get('REMOTE_ADDR', None),  
            request.META.get('X_REAL_IP', None),
            request.META.get('X_FORWARDED_FOR', None),
            ]
        self.ip = next((item for item in ip_addr if item is not None), None)
        if self.ip is None or self.ip is not is_valid_ip(self.ip):
            self.ip = request_settings.IP_DUMMY
            

No need to use ipware as @andhieka suggested.

Good library. Thanks

[Peskidk]

Wow. I just wasted a couple of hours just to get to the core of this. Even opened a topic here: #251

My fix for anybody who will need it:

import re
...

def is_valid_ip(ip):
    m = re.match(r"^(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})$", ip)
    return bool(m) and all(map(lambda n: 0 <= int(n) <= 255, m.groups()))

class Request(models.Model):
    ...

    def from_http_request(self, request, response=None, commit=True):
        ...
        ip_addr = [
            request.META.get('HTTP_REMOTE_ADDR', None),  
            request.META.get('HTTP_X_REAL_IP', None),
            request.META.get('HTTP_X_FORWARDED_FOR', None),
            request.META.get('REMOTE_ADDR', None),  
            request.META.get('X_REAL_IP', None),
            request.META.get('X_FORWARDED_FOR', None),
            ]
        self.ip = next((item for item in ip_addr if item is not None), None)
        if self.ip is None or self.ip is not is_valid_ip(self.ip):
            self.ip = request_settings.IP_DUMMY
            

No need to use ipware as @andhieka suggested.

Good library. Thanks

Great work. This definetly fixed the issue. My only problem now is, that the overview is gone from admin