Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove M2Crypto dependency #205

Closed
aprams opened this issue Apr 21, 2021 · 4 comments
Closed

Remove M2Crypto dependency #205

aprams opened this issue Apr 21, 2021 · 4 comments

Comments

@aprams
Copy link

aprams commented Apr 21, 2021

M2Crypto currently implies a heavy burden in terms of installing (see e.g. #176).

Using an alternative, more modern library might help to overcome this burden, which can not be easily solved an update in the requirements.txt.

An example would be this repository, which used the cryptography package:

https://github.com/anfema/django-ses-sns-tracker/blob/e65146fe204088f73c9240bef6cd8e416efb82f1/ses_sns_tracker/utils.py

I'm by no means an SSL expert, so I'm not sure about the comparability, but it would be a major QoL improvement.

@pcraciunoiu
Copy link
Contributor

@aprams thanks for filing and linking to a suggestion! Since I'm not actively using this package, it's tricky for me to do full hands-on testing. But, if you'd like to submit a PR that you've tested, I'm happy to review and try to get it tested and merged.

I like that it was introduced using a setting, so it could be the same here perhaps - giving people the option to stick with M2Crypto or choosing cryptography?

@joshsny
Copy link

joshsny commented May 12, 2021

+1 for this issue. Trying to use django-ses[events] in production on Heroku but can't find a way to install m2crypto. Any ideas for how to get round this?

I'd love to submit a PR, unfortunately I do not have the expertise :(

@joshsny
Copy link

joshsny commented May 12, 2021

For anyone looking at this who isn't bothered about verifying the events but just wants to receive them, setting AWS_SES_VERIFY_EVENT_SIGNATURES = False (not VERIFY_EVENT_SIGNATURES = False) did the trick.

Edit: I've submitted a PR to update the README with the correct flag.

@pcraciunoiu
Copy link
Contributor

#206 and it was merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants