Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event type fix and better AWS bounce setup instructions #178

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

mikob
Copy link
Contributor

@mikob mikob commented Jan 17, 2020

AWS notifications look like this:

{
  "Type" : "Notification",
  "MessageId" : "cd358678-b3e1-5281-9881-d0e35abe0a4c",
  "TopicArn" : "arn:aws:sns:us-west-(redacted):bounces_and_complaints",
  "Subject" : "Amazon SES Email Event Notification",
  "Message" : "{\"eventType\":\"Bounce\",
    \"bounce\":{
...

So this fixes the view code to look at the right property.

@pcraciunoiu
Copy link
Contributor

@mikob thanks for your contribution! This looks promising, however the tests/build fails. Could you fix?

Copy link
Contributor

@pcraciunoiu pcraciunoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge this and make a release

@pcraciunoiu pcraciunoiu merged commit 56ba5d6 into django-ses:master Jan 17, 2020
@znotdead
Copy link
Contributor

znotdead commented Feb 2, 2021

How do you have 'eventType'?
Mine response is notificationType
From response message is: {'notificationType': 'Bounce', ...
According to doc it's not true too. https://docs.aws.amazon.com/ses/latest/DeveloperGuide/notification-contents.html#top-level-json-object
So using django-ses I get warning in logs Received unknown event

@mrbaboon
Copy link

mrbaboon commented Feb 9, 2021

@znotdead 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants