Improve tests #260
Merged
Improve tests #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I did `poetry run python runtests.py` Django complained that the SECRET_KEY was required. After I ran tests once it doesn't seem to matter, but this was a small speedbump that I thought it might be nice for future users to not encounter.
pcraciunoiu
reviewed
Sep 30, 2022
.github/workflows/ci.yml
Outdated
| exclude: | ||
| - python-version: 3.7 | ||
| django-version: 40 | ||
| - python-version: 3.7 |
There was a problem hiding this comment.
Maybe we should move to python 3.10 as the default, and add it to the matrix too. I'm not sure if 3.7 support is still warranted, but I'm fine keeping it for now.
There was a problem hiding this comment.
I'm not sure how django-ses selects the default Python, but I'm happy to change it. I've added it to the gitlab test suite.
I'm not sure if 3.7 support is still warranted, but I'm fine keeping it for now.
Yeah I wanted to be conservative and I didn't need any changes that would require bumping the version. I'm happy to remove 3.7 from tests and pypi classifiers if you'd like.
Since it's out now and it works.
quodlibetor
force-pushed
the
improve-tests
branch
from
0fa6272
to
fa4c9ba
Compare
Specifically, 3.10 != 3.1
quodlibetor
force-pushed
the
improve-tests
branch
from
101cb2a
to
7db0a28
Compare
pcraciunoiu
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a small thanks for providing the library, I don't need you to merge it on my behalf. Let me know if you'd like me to change anything.
This has two commits:
Add SECRET_KEY to django config
When I did
poetry run python runtests.pyDjango complained that theSECRET_KEY was required. After I ran tests once it doesn't seem to matter, but
this was a small speedbump that I thought it might be nice for future users to
not encounter.
Configure tox to test against Django 4.1
Since it's out now and it works.