-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/return path #276
Merged
Merged
Fix/return path #276
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
12e0eb4
adicao de AWS_SES_FROM_EMAIL
peidrao 90b2d3d
update readme
peidrao 7c96401
Update README.rst
peidrao 1f54707
update readme
peidrao a62fb7f
correcao de parametros, variaveis e testes
peidrao f072204
arrumando concordancia de sentenca
peidrao 04fd97a
Update django_ses/__init__.py
peidrao a86adcc
Update README.rst
peidrao 0932c35
Update README.rst
peidrao df04922
Update tests/test_backend.py
peidrao 70064a0
Update tests/test_backend.py
peidrao 4097211
fix: correct assert in return path
peidrao 11284ae
update full list of settings readme
peidrao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is a breaking change, as it changes what
AWS_SES_RETURN_PATH
is used for right?What happens to an existing project if they upgrade to this new version but don't declare
AWS_SES_FROM_EMAIL
? Will something break?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
It will cause a breaking change on the following scenery
Before this change, this message would be sent with the
FromEmailAddress=my_default_from_email@email.com
.After this change, if the attribute
AWS_SES_FROM_EMAIL
is not set withAWS_SES_FROM_EMAIL=my_default_from_email@email.com
, the email will be sent with the from email of the EmailMessage, which would beFromEmailAddress=ignored_from_email@email.com
.The correct usage AFTER THE CHANGE would be
And this scenery could be a test itself! And it could act as a regression test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind, please add this example to the PR description and update the changelog, that will make it easier to merge this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!