Replaced flake8 with ruff and added it to CI #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks OK but I'd like to keep the same rules (longer lines mainly). I have to try it locally and see, haven't used ruff yet but I hear good things. Might take me a couple of weeks to get back to this. |
|
No worries. Do you have any concrete suggestions I can already add so you are happy with the PR itself? 🙂 |
pcraciunoiu
reviewed
Dec 1, 2023
| python-version: "3.12" | ||
|
|
||
| - name: Install required packages | ||
| run: pip install ruff |
There was a problem hiding this comment.
Should this be in poetry's dev dependencies, and get run on commit? Maybe we can add a pre-commit hook if one doesn't exist already.
There was a problem hiding this comment.
pre-commit sounds very good. I'll take care of it.
pcraciunoiu
approved these changes
Feb 4, 2024
|
@pcraciunoiu Awesome, thx! Had totally forgotten about this one 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pcraciunoiu
I realised that flake8 is not run in the CI. Since it's kinda deprecated and Ruff is the new cool kid on the block, I created a PR. Ruff has so many nice add-ons but I didn't want to bloat this PR, so I just used it as a drop-in replacement.
What do you think?
Best from Cologne
Ronny