Fix for #955 #1215
Merged
Fix for #955 #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this request? Any body? |
toastdriven
added a commit
that referenced
this pull request
Sep 26, 2014
|
Thanks, this fix looks good! Merged. |
|
Cool.. Btw I forgot to add myself to authors list. Do I need to send another request with that in? |
|
@harishnsrinivas Sure, that'd be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a ToOneField/ToManyField has a callable attribute that returns None, We get the issue #955 . I have sent a small fix and included a test case inside tests/core/fields.py - test_dehydrate_with_callable with field_3 that verifies an APIError return value(As per the fix). The message returned may not be the right one though. Please review and let me know if any more changes are required.