New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in support for Django 5.0 by adding in compat functionality for datetime_safe #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 4.1 has changed the name of _sanitize_token to _check_token_format - handle the case(s) where the new name is required to be imported, rather than the old one.
Add django 4.1 to the tests
Certain django versions don't support the old python versions
…en) and replaced it with a new function called _check_token_format. The signature of these two functions is different, handle both cases for backwards compatibility
…n import, but flake doesn't like that when it's inline with other code - it just wants one
…time safe - use the the same way
…eprecated django.utils.timezone.utc
…an the deprecated django.utils.timezone.utc" This reverts commit c8d9859.
@georgedorn can you please review and merge to add Django 5.0 support to tastypie? Thanks |
georgedorn
reviewed
Jan 9, 2024
@georgedorn should be good to go now -unless you have other changes? |
georgedorn
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds in support for Django 5.0 in Tastypie by doing the following: