resource urls now accept alphanumeric primary keys #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch works for me, too. |
|
Works here too, please pull this, it's awesome :) |
hadesgames
added a commit
to hadesgames/django-tastypie
that referenced
this pull request
May 27, 2012
|
Thanks! |
|
+1 on this. I just got bit by exactly this problem. The primary key for my model has dots in it. Not allowed. In my case, the punctuation is somewhat arbitrary so I worked around it by changing the dots to dashes, but none of this should be necessary. Allow anything that's not a slash in the pattern. |
|
roysmith, I just ran into the same problem where TastyPie coughs when the primary key contains a dot (.). I worked around the issue by replacing dots with underscores (_). |
georgedorn
added a commit
to georgedorn/django-tastypie
that referenced
this pull request
Aug 20, 2013
georgedorn
added a commit
to georgedorn/django-tastypie
that referenced
this pull request
Aug 20, 2013
|
Closed by #1013. |
nikmolnar
pushed a commit
to nikmolnar/django-tastypie
that referenced
this pull request
Jun 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an app with a Model imported from a table (inspectdb) with a CharField primary key. The patch supports other types as primary key with backwards compatibility.
By trying to get the object with a RESTful call, i was unable to get a object by primary key:
After applying this patch it works and tests passed for me.
Best Regards,
Jordi