Tests for pr829 #921
Merged
Tests for pr829 #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
tests-for-pr829
branch
from
339ac3a
to
d933626
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #921 +/- ##
=======================================
Coverage 88.36% 88.37%
=======================================
Files 55 55
Lines 2510 2512 +2
=======================================
+ Hits 2218 2220 +2
Misses 292 292
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
atodorov
force-pushed
the
tests-for-pr829
branch
2 times, most recently
from
e74bc73
to
89b87cf
Compare
atodorov
force-pushed
the
tests-for-pr829
branch
3 times, most recently
from
c6ab367
to
afbf509
Compare
…o-tenants#829 according to the description in django-tenants#829 Postgres will double quote schema names which contain underscores. More precisely names which contain underscores and a mixture of lower case and upper case letters will be quoted!
now the test uses schema names which will be double quoted by Postgres
This reverts commit 5f25990. The reported issue in django-tenants#829 is reproducible on Postgres 11 but not on later versions
b/c 4.1 is the last one to support Postgres 11
atodorov
force-pushed
the
tests-for-pr829
branch
from
afbf509
to
5559f5e
Compare
|
@atodorov looks good. Happy for you to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.