Merge pull request #1171 from atombrella/better_asserts

Improve a few asserts.
django-wiki · Feb 9, 2022 · 675061c · 675061c
2 parents 40a4220 + 76dabba
commit 675061c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/tests/core/test_accounts.py b/tests/core/test_accounts.py
@@ -83,7 +83,7 @@ def test_update_profile(self):
 
         test_auth = authenticate(username="admin", password="newPass")
 
-        self.assertNotEqual(test_auth, None)
+        self.assertIsNotNone(test_auth)
         self.assertEqual(test_auth.email, "test@test.com")
 
 

diff --git a/tests/core/test_basic.py b/tests/core/test_basic.py
@@ -19,7 +19,7 @@ def test_manager(self):
         root = URLPath.create_root()
         child = URLPath.create_urlpath(root, "child")
 
-        self.assertEqual(root.parent, None)
+        self.assertIsNone(root.parent)
         self.assertEqual(list(root.children.all().active()), [child])
 
 

diff --git a/tests/core/test_views.py b/tests/core/test_views.py
@@ -442,7 +442,7 @@ def test_preview_xframe_options_sameorigin(self):
 
         response = self.client.post(resolve_url("wiki:preview", path=""), example_data)
 
-        self.assertEquals(response.get("X-Frame-Options"), "SAMEORIGIN")
+        self.assertEqual(response.get("X-Frame-Options"), "SAMEORIGIN")
 
     def test_revision_conflict(self):
         """