Skip to content

Commit

Permalink
Merge pull request #1202 from Dev-Mehta/Dev-Mehta-Optimization-Of-Que…
Browse files Browse the repository at this point in the history
…ries

Optimized ArticleRevision queries and added tests for the same
  • Loading branch information
benjaoming committed Aug 11, 2022
2 parents f09f59f + 05ab8da commit ada24f8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/wiki/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ class Meta:
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
if self.instance.pk:
revisions = models.ArticleRevision.objects.filter(article=self.instance)
revisions = models.ArticleRevision.objects.select_related("article").filter(
article=self.instance
)
self.fields["current_revision"].queryset = revisions
else:
self.fields[
Expand Down
6 changes: 4 additions & 2 deletions src/wiki/views/article.py
Original file line number Diff line number Diff line change
Expand Up @@ -597,8 +597,10 @@ class History(ListView, ArticleMixin):
paginate_by = 10

def get_queryset(self):
return models.ArticleRevision.objects.filter(article=self.article).order_by(
"-created"
return (
models.ArticleRevision.objects.select_related("article")
.filter(article=self.article)
.order_by("-created")
)

def get_context_data(self, **kwargs):
Expand Down

0 comments on commit ada24f8

Please sign in to comment.