New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mediawiki import to docs #1348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 114 114
Lines 4737 4737
Branches 638 638
=======================================
Hits 3767 3767
Misses 759 759
Partials 211 211 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this and making sure the next one has a great resource to start with! 👏
I noticed you had put yourself as a narrator, which doesn't work very well in documentation, since it's unclear who's speaking :)
Leaving my input as suggestions that you can merge.
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
@benjaoming thank you for the suggestions everything's been merged ! |
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Hey friends, I think I have fixed all the requested changes, have I missed anything ? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spapas no, nothing missed, I just wanted to look at the rendered version*) finally before merging :)
*) https://django-wiki--1348.org.readthedocs.build/en/1348/tips/mediawiki.html
See the discussuion on #70