Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mediawiki import to docs #1348

Merged
merged 10 commits into from Mar 7, 2024
Merged

Add mediawiki import to docs #1348

merged 10 commits into from Mar 7, 2024

Conversation

spapas
Copy link
Contributor

@spapas spapas commented Mar 7, 2024

See the discussuion on #70

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (d4f9f44) to head (544df95).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1348   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         114      114           
  Lines        4737     4737           
  Branches      638      638           
=======================================
  Hits         3767     3767           
  Misses        759      759           
  Partials      211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this and making sure the next one has a great resource to start with! 👏

I noticed you had put yourself as a narrator, which doesn't work very well in documentation, since it's unclear who's speaking :)

Leaving my input as suggestions that you can merge.

docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
docs/tips/mediawiki.rst Show resolved Hide resolved
docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
spapas and others added 8 commits March 7, 2024 12:26
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
@spapas
Copy link
Contributor Author

spapas commented Mar 7, 2024

@benjaoming thank you for the suggestions everything's been merged !

docs/tips/mediawiki.rst Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
@oscarmcm oscarmcm self-requested a review March 7, 2024 14:21
@oscarmcm oscarmcm added this to the 0.11 milestone Mar 7, 2024
@spapas
Copy link
Contributor Author

spapas commented Mar 7, 2024

Hey friends, I think I have fixed all the requested changes, have I missed anything ?

Thank you

Copy link
Member

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spapas no, nothing missed, I just wanted to look at the rendered version*) finally before merging :)

*) https://django-wiki--1348.org.readthedocs.build/en/1348/tips/mediawiki.html

@benjaoming benjaoming merged commit b0bd140 into django-wiki:main Mar 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants