Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed conversions to lists for generators #735

Merged
merged 1 commit into from Dec 7, 2017

Conversation

atombrella
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #735 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   69.93%   69.93%           
=======================================
  Files          89       89           
  Lines        4417     4417           
=======================================
  Hits         3089     3089           
  Misses       1328     1328
Impacted Files Coverage Δ
src/wiki/plugins/attachments/forms.py 63.71% <ø> (ø) ⬆️
src/wiki/models/urlpath.py 81.96% <100%> (ø) ⬆️
src/wiki/urls.py 97.4% <100%> (ø) ⬆️
src/wiki/plugins/macros/mdx/toc.py 75.92% <100%> (ø) ⬆️
src/wiki/views/article.py 65.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8593b1e...db8b5aa. Read the comment docs.

@atombrella
Copy link
Contributor Author

It should speed up things a bit.

Copy link
Member

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe, 100% diff coverage and all of the "has-been lists" are used within the same tested blocks

@benjaoming benjaoming merged commit 697b66e into django-wiki:master Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants