Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image deletion issue caused by S3 storage fix #912

Merged
merged 3 commits into from Oct 16, 2018

Conversation

benjaoming
Copy link
Member

Fixes #911

This fixes some code that may have been introduced through a merging issue. I don't know -- but it addresses something that was assumed fixed and is already in the changelog, so will not add it again :)

@benjaoming benjaoming added the bug Confirmed bug label Oct 15, 2018
@benjaoming benjaoming added this to the 0.4 milestone Oct 15, 2018
@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #912 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   74.24%   74.31%   +0.06%     
==========================================
  Files         106      106              
  Lines        4330     4326       -4     
==========================================
  Hits         3215     3215              
+ Misses       1115     1111       -4
Impacted Files Coverage Δ
src/wiki/plugins/images/models.py 56.47% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a144a31...36c5dd6. Read the comment docs.

@benjaoming
Copy link
Member Author

I'm waiting to see if the CodeCov report that was posted earlier will eventually update or if there's a bug with their system..

@benjaoming
Copy link
Member Author

Bug reported to CodeCov yesterday, but I give up about the comment not being updated.

@benjaoming benjaoming merged commit 4be3b53 into django-wiki:master Oct 16, 2018
@benjaoming benjaoming deleted the notimplementederrorERROR branch November 16, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NotImplemented is not an exception
1 participant