Skip to content

Commit

Permalink
Don't warn 'non-async-marked callable' for async callable instance (#325
Browse files Browse the repository at this point in the history
)

Look for `__call__` methods on the awaitable as well as checking it directly.
  • Loading branch information
flaeppe committed May 10, 2022
1 parent 12f6355 commit ab7379a
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
7 changes: 6 additions & 1 deletion asgiref/sync.py
Expand Up @@ -107,7 +107,12 @@ class AsyncToSync:
loop_thread_executors: "Dict[asyncio.AbstractEventLoop, CurrentThreadExecutor]" = {}

def __init__(self, awaitable, force_new_loop=False):
if not callable(awaitable) or not _iscoroutinefunction_or_partial(awaitable):
if not callable(awaitable) or (
not _iscoroutinefunction_or_partial(awaitable)
and not _iscoroutinefunction_or_partial(
getattr(awaitable, "__call__", awaitable)
)
):
# Python does not have very reliable detection of async functions
# (lots of false negatives) so this is just a warning.
warnings.warn(
Expand Down
24 changes: 24 additions & 0 deletions tests/test_sync.py
Expand Up @@ -3,6 +3,7 @@
import multiprocessing
import threading
import time
import warnings
from concurrent.futures import ThreadPoolExecutor
from functools import wraps
from unittest import TestCase
Expand Down Expand Up @@ -365,6 +366,29 @@ async def inner_async_function(*args):
assert result["worked"]


def test_async_to_sync_on_callable_object():
"""
Tests async_to_sync on a callable class instance
"""

result = {}

class CallableClass:
async def __call__(self, value):
await asyncio.sleep(0)
result["worked"] = True
return value

# Run it (without warnings)
with warnings.catch_warnings():
warnings.simplefilter("error")
sync_function = async_to_sync(CallableClass())
out = sync_function(42)

assert out == 42
assert result["worked"] is True


def test_async_to_sync_method_self_attribute():
"""
Tests async_to_sync on a method copies __self__.
Expand Down

0 comments on commit ab7379a

Please sign in to comment.