Fix deprecation warnings for python 3.10 #262
Conversation
asyncio.get_event_loop was marked as deprecated, the documnetation now refers to asyncio.get_running_loop([1]) asyncio.ensure_future issues a deprecation warning if there is no running event loop([2]), so use asyncio.run which creates and destroys the loop itself asyncio.gather issues a warning if run outside of event loop (i.e. there is no running event loop)([3]), so wrap it into an async def explicit passing of coroutine objects to asyncio.wait is deprecated since 3.8([4]), so wrap them in asyncio.create_task plus, add 3.10 to tox.ini [1]: https://docs.python.org/3.10/library/asyncio-eventloop.html#asyncio.get_event_loop [2]: https://docs.python.org/3.10/library/asyncio-future.html#asyncio.ensure_future [3]: https://docs.python.org/3.10/library/asyncio-task.html#asyncio.gather [4]: https://docs.python.org/3.10/library/asyncio-task.html#asyncio.wait
|
I have separated things that were added in 3.7 and added a version check. All the changes now use the things added in 3.7 if |
|
Thanks for your work on this. I can't say for upstream but I really appreciate the effort you've put to make this neat. |
Upstream PR: django/asgiref#262 Signed-off-by: Ekaterina Vaartis <vaartis@kotobank.ch>
Upstream PR: django/asgiref#262 Signed-off-by: Ekaterina Vaartis <vaartis@kotobank.ch>
Upstream PR: django/asgiref#262 Signed-off-by: Ekaterina Vaartis <vaartis@kotobank.ch> Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
Thanks for this! Were you testing this against Django, Flask, or something else? Due to the nature of the change I'll have to manually run some tests to make sure we didn't introduce subtle breakage and it'd be nice to know if some of those areas are already covered. |
Django, at least the test suite, did pass. However I didn't test anything on 3.6, only 3.8 and 3.10. |
Great, thanks for that. I'm not too worried about 3.6 since this patch barely changes behaviour for it - I'll run a few extra tests with some weird async Django apps I have to make sure and then I'll get this into a release. |
asyncio.get_event_loop was marked as deprecated, the documnetation
now refers to asyncio.get_running_loop(1)
asyncio.ensure_future issues a deprecation warning if there is no
running event loop(2), so use asyncio.run which creates and destroys the
loop itself
asyncio.gather issues a warning if run outside of event
loop (i.e. there is no running event loop)(3), so wrap it into an
async def
explicit passing of coroutine objects to asyncio.wait is deprecated
since 3.8(4), so wrap them in asyncio.create_task
plus, add 3.10 to tox.ini