Remove constraints about waiting for body to send response #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
changed the title
andrewgodwin
approved these changes
May 2, 2023
|
Yes, it was indeed inherited from WSGI! I think it's fine to remove it given it's not followed and the world hasn't collapsed :) |
|
Thanks Andrew 🙏 |
|
Well, that clears that up :) |
This was referenced May 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other day I noticed those words in the spec, and neither Uvicorn or the Starlette TestClient are following this "wait for body" constraints.
This looks like it was inherited from WSGI? (I'm not sure)
Fixes #388