Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.7 #1108

Closed
denself opened this issue Jul 19, 2018 · 5 comments
Closed

Support for Python 3.7 #1108

denself opened this issue Jul 19, 2018 · 5 comments

Comments

@denself
Copy link

denself commented Jul 19, 2018

Is it possible to add support for the installation of channels from pip on Python 3.7?
I checked through the direct installation of the library from git, it seems to work fine with the latest version of twisted (18.7.0), all tests passed.

@andrewgodwin
Copy link
Member

What aspect of installing via pip does not work? There was no 3.7 classifier on the package (I've fixed that for the next release), but the actual installation should not have failed...

@denself
Copy link
Author

denself commented Jul 23, 2018

Pip could not find a version that would satisfy requirements before

  Could not find a version that satisfies the requirement channels (from versions: )
No matching distribution found for channels

But now it looks like everything with channels classifiers fine, but twisted doesn't provide a proper classifier:

...
  Could not find a version that satisfies the requirement twisted>=18.7 (from daphne~=2.2->channels) (from versions: )
No matching distribution found for twisted>=18.7 (from daphne~=2.2->channels)

Is there a way to request Python 3.7 support from twisted? (Sorry, I know it's not relevant to this repo question)

@andrewgodwin
Copy link
Member

Pip shouldn't be using classifiers to select if packages are downloadable or not - I just tried a Python 3.7 version of pip and it happily downloads twisted. Do you have some sort of strange setup?

(I'm going to close the ticket too, as we have support for 3.7 at least)

@adonese
Copy link

adonese commented Sep 22, 2018

Channels support python 3.7 but twisted doesn't (as of version 18.7, from pip error message). They are working on adding support for python 3.7, so you might wait for that or use python 3.6
What i've done is building twisted from the source without relying on pip to do that.

@luskbo
Copy link

luskbo commented Sep 25, 2018

Just FYI, for anyone that comes across this issue. Like adonese, i was successful only after manually installing Twisted-18.7.0 from source. With pip, I installed all versions from 3.6.0 to 3.7.0 and all failed with Could not find a version that satisfies the requirement twisted>=18.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants