New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leading whitespace in cookie middleware #1983

Merged

carltongibson merged 2 commits into django:main from eirsyl:sylliaas/remove-leading-whitespace

Mar 9, 2023

Contributor

eirsyl commented Mar 8, 2023

Looks like the same issue as this PR #1130 fixed.

h11 does not allow header values with leading or trailing whitespace.

eirsyl and others added 2 commits

March 8, 2023 20:36


          Remove leading whitespace in cookie middleware

31bdc26


          Added regression test for set_cookie().

ef1a8b9

carltongibson approved these changes

View reviewed changes

Member

carltongibson left a comment

Great. Thanks. I added a regression test.

carltongibson merged commit 5041475 into django:main

eirsyl deleted the sylliaas/remove-leading-whitespace branch

March 10, 2023 10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment