Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: django conf should not be modified #341

Closed
wants to merge 2 commits into from
Closed

fix: django conf should not be modified #341

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cfc2ea
fix: django conf should not be modified
Nov 16, 2022
4a4d8c0
Update channels_redis/core.py
techblack Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions channels_redis/core.py
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@

import msgpack
from redis import asyncio as aioredis

from copy import deepcopy
from channels.exceptions import ChannelFull
from channels.layers import BaseChannelLayer

Expand Down Expand Up @@ -132,13 +132,14 @@ def create_pool(self, index):
if "address" in host:
return aioredis.ConnectionPool.from_url(host["address"])
elif "master_name" in host:
sentinels = host.pop("sentinels")
master_name = host.pop("master_name")
sentinel_kwargs = host.pop("sentinel_kwargs", None)
host_kwargs = deepcopy(host)
sentinels = host_kwargs.pop("sentinels")
master_name = host_kwargs.pop("master_name")
sentinel_kwargs = host_kwargs.pop("sentinel_kwargs", None)
techblack marked this conversation as resolved.
Show resolved Hide resolved
return aioredis.sentinel.SentinelConnectionPool(
master_name,
aioredis.sentinel.Sentinel(sentinels, sentinel_kwargs=sentinel_kwargs),
**host
**host_kwargs
)
else:
return aioredis.ConnectionPool(**host)
Expand Down