Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell asyncio which is the current event loop #300

Closed
wants to merge 1 commit into from

Conversation

Matbj
Copy link

@Matbj Matbj commented Jan 8, 2020

Solves #299

@carltongibson
Copy link
Member

I'll test this but I strongly suspect it will lead to the exact issue in django/channels#1374, which prompted the change in Daphne, after consultation with Folks Who Know™.

As per comment on #299, I think we're in a half-way land at the moment, and we need to be passing the running loop to Lock (using asyncio.get_running_loop()) until Lock.__init__() stops using get_event_loop() itself.

Base automatically changed from master to main March 3, 2021 18:20
@carltongibson
Copy link
Member

Closing as per ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants