Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP201, exception raised when type conversion fails #37

Closed
uranusjr opened this issue Dec 30, 2016 · 1 comment
Closed

DEP201, exception raised when type conversion fails #37

uranusjr opened this issue Dec 30, 2016 · 1 comment

Comments

@uranusjr
Copy link

Failure to perform a type conversion against a captured string should result in an Http404 exception being raised.

Reading the actual implementation django/django#7482 I’m wondering whether this should be Resolver404 instead. Type conversion failure seems symmetric to a regex non-match in the current style, which raises Resolver404. I understand Resolver404 is implemented as an Http404 subclass, but that seems like implementation detail (or maybe I’m wrong).
@timgraham
Copy link
Member

"Http404" no longer appears in the DEP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timgraham @uranusjr