Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that Releasers may make admin commits. #67

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

carltongibson
Copy link
Member

@carltongibson carltongibson commented Mar 10, 2020

Releasers need to make a series of administrative commits in order to release Django.
They need to be allowed to do this without approval, which wouldn't be practical.

Releases need to make a series of administrative commits in order to release Django. 
They need to be allowed to do this without approval, which wouldn't be practical.
@felixxm
Copy link
Member

felixxm commented Mar 10, 2020

I was also thinking about a small change that should make mergers life easier with keeping "approval" policy:

"Any Merger MAY, on their own initiative, merge any pull request which constitutes a Minor Change, with one exception: a Merger MUST NOT merge a Minor Change primarily authored by that Merger, unless the pull request has been approved by another Merger, by a Technical Board member, or by the Django Security Team."

i.e. "a Technical Board member" instead of "the Technical Board".

For example django/django#12540 (minor PR from "merger" approved by a technical board member).

@carltongibson
Copy link
Member Author

i.e. "a Technical Board member" instead of "the Technical Board".

Yes. Actually this is important: @charettes, who as a Technical Board member would not be eligible as a Merger, plays a vital role reviewing PRs (particularly on the ORM). "@felixxm makes a PR, @charettes approves, @felixxm merges" is an important flow to maintain.

@ubernostrum ubernostrum merged commit 2c82839 into master Mar 12, 2020
@felixxm felixxm deleted the release-admin-commits branch March 12, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants