Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query dates benchmark added #24

Merged
merged 1 commit into from Jun 4, 2022

Conversation

deepakdinesh1123
Copy link
Contributor

list(Book.objects.dates("created_date", "year", "ASC"))
list(Book.objects.dates("created_date", "year", "DESC"))
list(Book.objects.dates("created_date", "month", "ASC"))
list(Book.objects.dates("created_date", "month", "DESC"))
list(Book.objects.dates("created_date", "day", "ASC"))
list(Book.objects.dates("created_date", "day", "DESC"))

Should I add separate benchmarks for different queries?

@smithdc1
Copy link
Member

smithdc1 commented Jun 4, 2022

I think it's fine to have it in a single benchmark.

@smithdc1 smithdc1 merged commit f2566b9 into django:main Jun 4, 2022
@deepakdinesh1123 deepakdinesh1123 deleted the query_dates_bench branch June 6, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants