Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark workflow modified to commit results and publish-results workflow added #38

Merged
merged 3 commits into from Jun 21, 2022

Conversation

deepakdinesh1123
Copy link
Contributor

  • publish-results workflow now publishes the benchmarks results to the gh-pages branch
  • benchmarks.yml workflow now runs the benchmarks against the last 10 commits and since --skip-existing option is used the exiting benchmarks won't run again

runs-on: ubuntu-latest
strategy:
matrix:
os: ['ubuntu-22.04', 'windows-2022', 'macos-12']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results shared for these systems are all very similar. I'm not sure we need to test on all systems right now. Can we just use Ubuntu for now and can discuss adding the others as a separate PR.

I'm thinking about the environmental impact of running the same thing three times where it is rather unlikely we will see any difference.

I'd be much more interested in seeing results for multiple python versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added versions 3.10, 3.9, and 3.8. Please let me know which versions I should add

.github/workflows/publish-results.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
Copy link
Member

@smithdc1 smithdc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good to me. Let's merge this, it will be great to start seeing some results. 👀

Suspect I'll need to configure the gh-pages in the settings of this repo. 🤔

asv.conf.json Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Show resolved Hide resolved
@smithdc1
Copy link
Member

@deepakdinesh1123 have you seen the action failures with the current version of this PR?

https://github.com/smithdc1/django-asv/actions/runs/2529414916

@deepakdinesh1123
Copy link
Contributor Author

The benchmark workflow is calling the publish-results workflow which I have added in this PR but it is not in main, I have run this workflow on a PR in my repository here. Once publish-results gets added the workflows can be run

@smithdc1
Copy link
Member

The benchmark workflow is calling the publish-results workflow which I have added in this PR but it is not in main, I have run this workflow on a PR in my repository here. Once publish-results gets added the workflows can be run

Thank you for your time to explain this to me.

Let's merge it 👍

@smithdc1 smithdc1 self-requested a review June 21, 2022 19:45
@smithdc1 smithdc1 changed the title benchmark workflow modified to include different systems and publish-results workflow added Benchmark workflow modified to commit results and publish-results workflow added Jun 21, 2022
@smithdc1 smithdc1 merged commit 1db6be1 into django:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants