New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark workflow modified to commit results and publish-results workflow added #38
Benchmark workflow modified to commit results and publish-results workflow added #38
Conversation
.github/workflows/benchmark.yml
Outdated
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
os: ['ubuntu-22.04', 'windows-2022', 'macos-12'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The results shared for these systems are all very similar. I'm not sure we need to test on all systems right now. Can we just use Ubuntu for now and can discuss adding the others as a separate PR.
I'm thinking about the environmental impact of running the same thing three times where it is rather unlikely we will see any difference.
I'd be much more interested in seeing results for multiple python versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added versions 3.10, 3.9, and 3.8. Please let me know which versions I should add
b377bc0
to
effc6f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, looks good to me. Let's merge this, it will be great to start seeing some results. 👀
Suspect I'll need to configure the gh-pages in the settings of this repo. 🤔
@deepakdinesh1123 have you seen the action failures with the current version of this PR? https://github.com/smithdc1/django-asv/actions/runs/2529414916 |
The |
Thank you for your time to explain this to me. Let's merge it 👍 |
gh-pages
branch--skip-existing
option is used the exiting benchmarks won't run again