Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Truncator Benchmarks #70

Closed
wants to merge 2 commits into from
Closed

Added Truncator Benchmarks #70

wants to merge 2 commits into from

Conversation

smithdc1
Copy link
Member

@smithdc1 smithdc1 commented Jan 6, 2023

Added benchmarks for ticket #30686

@carltongibson -- Can I add this to your list? Aim is then to try and use the benchmark label on django/django

@smithdc1
Copy link
Member Author

smithdc1 commented Jan 6, 2023

May be a bit much to add this permanently to the benchmark suite 🤷

@carltongibson
Copy link
Member

Super. Thanks @smithdc1 — I will take a look next week! 👍

@smithdc1
Copy link
Member Author

smithdc1 commented Jan 9, 2023

Just a short note to say I expect these benchmarks to show my current patch is much much slower (20x?!) for short truncations.

I've got a fix which will make it faster (2x?), but it needs more work to refine it.

So while I'd like it considering if these are suitable benchmarks. I need a bit more time to refine my proposed patch.

Something like asv continuous main [my prs commit hash] should show the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants