fix: Accept French Postal Services identifiers in forms

django · Apr 22, 2024 · 1baf78b · 1baf78b
1 parent a0bb1b5
commit 1baf78b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/docs/authors.rst b/docs/authors.rst
@@ -32,6 +32,7 @@ Authors
 * Ben Konrath
 * Bruno M. Custódio
 * Burhan Khalid
+* Célia Prat
 * Claude Paroz
 * Daniel Ampuero
 * Daniela Ponader

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -16,6 +16,8 @@ Modifications to existing flavors:
 
 - Fix Belarus passport field description punctuation
   (`gh-484 <https://github.com/django/django-localflavor/pull/484>`_).
+- Accept French Postal Services identifiers in forms
+  (`gh-505 <https://github.com/django/django-localflavor/pull/505>`_).
 
 Other changes:
 

diff --git a/localflavor/fr/forms.py b/localflavor/fr/forms.py
@@ -193,7 +193,8 @@ def clean(self, value):
             return value
 
         value = value.replace(' ', '').replace('-', '')
-        if not self.r_valid.match(value) or not luhn.is_valid(value):
+        if ((not self.r_valid.match(value) or not luhn.is_valid(value)) and not
+                (value.startswith("356000000") and sum(int(x) for x in value) % 5 == 0)):
             raise ValidationError(self.error_messages['invalid'], code='invalid')
         return value
 

diff --git a/tests/test_fr.py b/tests/test_fr.py
@@ -271,10 +271,12 @@ def test_FRSIRENNumber(self):
             '752932715': '752932715',
             '752 932 715': '752932715',
             '752-932-715': '752932715',
+            '35600000014597' : '35600000014597'
         }
         invalid = {
             '1234': error_format,               # wrong size
             '752932712': error_format,     # Bad luhn on SIREN
+            '35600000014596' : error_format
         }
         self.assertFieldOutput(FRSIRENField, valid, invalid)