Support 17X cellphone number in China (virtual ISPs) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,7 +201,7 @@ class CNCellNumberField(RegexField): | |||
| A valid cell number could be like: 13012345678 | |||
|
|
|||
| We used a rough rule here, the first digit should be 1, the second could be | |||
| 3, 5 and 8, the rest could be what so ever. | |||
| 3, 4, 5, 7 and 8, the rest could be what so ever. | |||
| The length of the cell number should be 11. | |||
| """ | |||
There was a problem hiding this comment.
Could you add a versionchanged statement about adding 7 in here? See dc14842 for an example.
Also, while we're updating this, let's patch up the language a little. I suggest:
- the second could -> the second should
- and 8 -> or 8
- the rest could be what so ever -> followed by 9 more digits
(Especially emphasized those mainland-specific rules.)
|
@erikr Thanks! I just made two more commits, dealing with general language problems and versionchanged statements. |
|
Thanks, committed in ae402af! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
China has recently allowed "virutal mobile ISPs" and assigned them with cellphone numbers starting with 17 (still 11 digits in total).
I've updated the regular expression, doc and tests.