Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SE] Added support for interim personal identity numbers (interimspersonnummer) #308

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

ovidner
Copy link
Contributor

@ovidner ovidner commented Aug 29, 2017

Added support for interim personal identity numbers (interimspersonnummer) to the existing SEPersonalIdentityNumberField. Interim numbers are used instead of coordination numbers by Swedish educational institutions, within the Ladok system. It is disabled by default since most projects will probably not need (or want) it.

There is more information about interimspersonnummer available (in Swedish) at https://wiki.swami.se/display/Inkubator/norEduPersonNIN+och+Svenska+Personnummer and https://confluence.its.umu.se/confluence/display/LDSV/Interimspersonnummer

All Changes

  • Add an entry to the docs/changelog.rst describing the change.

  • Add an entry for your name in the docs/authors.rst file if it's not
    already there.

  • Adjust your imports to a standard form by running this command:

    `isort --recursive --line-width 120 localflavor tests`
    

@ovidner ovidner force-pushed the master branch 2 times, most recently from 918c64e to 68ac45b Compare August 30, 2017 13:51
@codecov-io
Copy link

codecov-io commented Aug 30, 2017

Codecov Report

Merging #308 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   96.28%   96.29%   +<.01%     
==========================================
  Files         152      152              
  Lines        4230     4239       +9     
  Branches      579      582       +3     
==========================================
+ Hits         4073     4082       +9     
  Misses         98       98              
  Partials       59       59
Impacted Files Coverage Δ
localflavor/se/utils.py 88.09% <100%> (+0.59%) ⬆️
localflavor/se/forms.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067ed1c...68ac45b. Read the comment docs.

@benkonrath benkonrath merged commit 8871910 into django:master Sep 7, 2017
@benkonrath
Copy link
Member

PR looks good. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants