Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FRRNAField #443

Merged
merged 4 commits into from Apr 7, 2023
Merged

Add FRRNAField #443

merged 4 commits into from Apr 7, 2023

Conversation

babastienne
Copy link
Contributor

@babastienne babastienne commented Jun 10, 2021

Added FRRNAField to allow the use of RNA French Association Identification Number.
More information on https://fr.wikipedia.org/wiki/R%C3%A9pertoire_national_des_associations or https://www.associations.gouv.fr/le-rna-repertoire-national-des-associations.html

All Changes

  • Add an entry to the docs/changelog.rst describing the change.

  • Add an entry for your name in the docs/authors.rst file if it's not
    already there.

New Fields Only

  • Prefix the country code to all fields.

  • Field names should be easily understood by developers from the target
    localflavor country. This means that English translations are usually
    not the best name unless it's for something standard like postal code,
    tax / VAT ID etc.

  • Add meaningful tests. 100% test coverage is not required but all
    validation edge cases should be covered.

  • Add .. versionadded:: <next-version> comment markers to new
    localflavors.

  • Add documentation for all fields.

@benkonrath benkonrath added this to the 4.0 milestone Jan 13, 2022
@benkonrath benkonrath mentioned this pull request Mar 31, 2023
@benkonrath
Copy link
Member

Thanks for the PR. Sorry for the delay in merging it.

@benkonrath benkonrath merged commit a07a2f2 into django:master Apr 7, 2023
8 checks passed
@babastienne babastienne deleted the add_rna_fr branch April 10, 2023 15:04
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Dec 2, 2023
4.0   (2023-04-22)
------------------

New flavors:

- Nepal LocalFlavor: Support for Nepal added
  (`gh-451 <https://github.com/django/django-localflavor/pull/451>`_).
- Belarus localflavor
  (`gh-422 <https://github.com/django/django-localflavor/pull/422>`_,
  `gh-442 <https://github.com/django/django-localflavor/pull/442>`_).
- Ghana localflavor
  (`gh-460 <https://github.com/django/django-localflavor/pull/460>`_).

New fields for existing flavors:

- Added `fr.forms.FRRNAField` models field
  (`gh-443 <https://github.com/django/django-localflavor/pull/443>`_).
- Added permanent account number(PAN) field in Indian flavor.
  (`gh-457 <https://github.com/django/django-localflavor/pull/457>`_).
- Added the Canadian Models fields.
  (`gh-465 <https://github.com/django/django-localflavor/pull/465>`_).

Modifications to existing flavors:

- Properly validate IBANs using BBAN to ensure invalid IBANs cannot be entered,
  updated IBAN_SEPA_COUNTRIES and IBAN_COUNTRY_CODE_LENGTH to latest data
  (`gh-486 <https://github.com/django/django-localflavor/pull/486>`_).
- Fix typo in Marijampolė county name in LTCountySelect
  (`gh-480 <https://github.com/django/django-localflavor/pull/480>`_).
- Add support for new Finnish identity codes
  (`gh-478 <https://github.com/django/django-localflavor/pull/478>`_).
- CIF spanish starting with 'U' bug resolved
  (`gh-469 <https://github.com/django/django-localflavor/pull/469>`_).
- Fix error code for BRPostalCodeValidator
  (`gh-448 <https://github.com/django/django-localflavor/pull/448>`_).
- Fix spelling of the India state of Chhattisgarh
  (`gh-444 <https://github.com/django/django-localflavor/pull/444>`_).
- Fix CURP regex for MX flavor
  (`gh-449 <https://github.com/django/django-localflavor/pull/449>`_).
- Change text based fields that inherited from `django.forms.Field` to inherit from `django.forms.CharField`. The
  following fields have been updated
  (`gh-446 <https://github.com/django/django-localflavor/pull/446>`_):

  - `at.forms.ATSocialSecurityNumberField`
  - `br.forms.BRStateChoiceField`
  - `ca.forms.CAProvinceField`
  - `ca.forms.CASocialInsuranceNumberField`
  - `ch.forms.CHIdentityCardNumberField`
  - `cu.forms.CUProvinceField`
  - `cu.forms.CURegionField`
  - `cz.forms.CZBirthNumberField`
  - `cz.forms.CZICNumberField`
  - `de.forms.DEIdentityCardNumberField`
  - `ee.forms.EEBusinessRegistryCode`
  - `ee.forms.EEPersonalIdentificationCode`
  - `fi.forms.FISocialSecurityNumber`
  - `gr.forms.GRTaxNumberCodeField`
  - `hr.forms.HRJMBAGField`
  - `hr.forms.HRJMBGField`
  - `hr.forms.HRLicensePlateField`
  - `hr.forms.HRPostalCodeField`
  - `id_.forms.IDLicensePlateField`
  - `id_.forms.IDNationalIdentityNumberField`
  - `id_.forms.IDPostCodeField`
  - `il.forms.ILIDNumberField`
  - `in_.forms.INAadhaarNumberField`
  - `in_.forms.INStateField`
  - `ir.forms.IRIDNumberField`
  - `it.forms.ITVatNumberField`
  - `lt.forms.LTPostalCodeField`
  - `lv.forms.LVPersonalCodeField`
  - `lv.forms.LVPostalCodeField`
  - `no.forms.NOSocialSecurityNumber`
  - `nz.forms.NZBankAccountNumberField`
  - `pt.forms.PTCitizenCardNumberField`
  - `pt.forms.PTSocialSecurityNumberField`
  - `ro.forms.ROCountyField`
  - `tr.forms.TRIdentificationNumberField`
  - `us.forms.USStateField`
- Removed inconvenient word VACA from CURP_INCONVENIENT_WORDS for MX flavor

Other changes:

- Use 'return value' when value is in the empty_values list
  (`gh-461 <https://github.com/django/django-localflavor/pull/461>`_).

- Dropped support for Django 2.2, 3.0 and 3.1.

- Dropped support for Python 3.5.

- Added support for Python 3.10 and 3.11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants