Skip to content

Commit

Permalink
Fixed #28866 -- Made InlineAdminFormSet include InlineModelAdmin's Me…
Browse files Browse the repository at this point in the history
…dia before its formset's Media.

This provides better backwards compatibility following refs #28377.
  • Loading branch information
clincher authored and timgraham committed Dec 1, 2017
1 parent e50add6 commit 03974d8
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
2 changes: 1 addition & 1 deletion django/contrib/admin/helpers.py
Expand Up @@ -304,7 +304,7 @@ def non_form_errors(self):

@property
def media(self):
media = self.formset.media + self.opts.media
media = self.opts.media + self.formset.media
for fs in self:
media = media + fs.media
return media
Expand Down
9 changes: 9 additions & 0 deletions tests/admin_inlines/admin.py
@@ -1,5 +1,6 @@
from django import forms
from django.contrib import admin
from django.db import models

from .models import (
Author, BinaryTree, CapoFamiglia, Chapter, ChildModel1, ChildModel2,
Expand Down Expand Up @@ -73,8 +74,16 @@ class Media:
js = ('my_awesome_inline_scripts.js',)


class CustomNumberWidget(forms.NumberInput):
class Media:
js = ('custom_number.js',)


class InnerInline3(admin.StackedInline):
model = Inner3
formfield_overrides = {
models.IntegerField: {'widget': CustomNumberWidget},
}

class Media:
js = ('my_awesome_inline_scripts.js',)
Expand Down
10 changes: 10 additions & 0 deletions tests/admin_inlines/tests.py
Expand Up @@ -453,6 +453,16 @@ def test_inline_media_only_inline(self):
Inner3(dummy=42, holder=holder).save()
change_url = reverse('admin:admin_inlines_holder3_change', args=(holder.id,))
response = self.client.get(change_url)
self.assertEqual(
response.context['inline_admin_formsets'][0].media._js,
[
'admin/js/vendor/jquery/jquery.min.js',
'admin/js/jquery.init.js',
'admin/js/inlines.min.js',
'my_awesome_inline_scripts.js',
'custom_number.js',
]
)
self.assertContains(response, 'my_awesome_inline_scripts.js')

def test_all_inline_media(self):
Expand Down

0 comments on commit 03974d8

Please sign in to comment.