Skip to content

Commit

Permalink
Fixed #33228 -- Changed value of BaseDatabaseFeatures.has_case_insens…
Browse files Browse the repository at this point in the history
…itive_like to False.
  • Loading branch information
chinmoy12c committed Oct 28, 2021
1 parent 8e3b1cf commit 073b7b5
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion django/db/backends/base/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ class BaseDatabaseFeatures:
closed_cursor_error_class = ProgrammingError

# Does 'a' LIKE 'A' match?
has_case_insensitive_like = True
has_case_insensitive_like = False

# Suffix for backends that don't support "SELECT xxx;" queries.
bare_select_suffix = ''
Expand Down
1 change: 0 additions & 1 deletion django/db/backends/mysql/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
supports_select_difference = False
supports_slicing_ordering_in_compound = True
supports_index_on_text_field = False
has_case_insensitive_like = False
create_test_procedure_without_params_sql = """
CREATE PROCEDURE test_procedure ()
BEGIN
Expand Down
1 change: 0 additions & 1 deletion django/db/backends/oracle/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
# does by uppercasing all identifiers.
ignores_table_name_case = True
supports_index_on_text_field = False
has_case_insensitive_like = False
create_test_procedure_without_params_sql = """
CREATE PROCEDURE "TEST_PROCEDURE" AS
V_I INTEGER;
Expand Down
1 change: 0 additions & 1 deletion django/db/backends/postgresql/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
supports_combined_alters = True
nulls_order_largest = True
closed_cursor_error_class = InterfaceError
has_case_insensitive_like = False
greatest_least_ignores_nulls = True
can_clone_databases = True
supports_temporal_subtraction = True
Expand Down
1 change: 1 addition & 0 deletions django/db/backends/sqlite3/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class DatabaseFeatures(BaseDatabaseFeatures):
supports_cast_with_precision = False
time_cast_precision = 3
can_release_savepoints = True
has_case_insensitive_like = True
# Is "ALTER TABLE ... RENAME COLUMN" supported?
can_alter_table_rename_column = Database.sqlite_version_info >= (3, 25, 0)
supports_parentheses_in_compound = False
Expand Down
3 changes: 2 additions & 1 deletion docs/releases/4.1.txt
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ Database backend API
This section describes changes that may be needed in third-party database
backends.

* ...
* ``BaseDatabaseFeatures.has_case_insensitive_like`` is changed from ``True``
to ``False`` to reflect the behavior of most databases.

Dropped support for MariaDB 10.2
--------------------------------
Expand Down

0 comments on commit 073b7b5

Please sign in to comment.