[1.6.x] Fix #21185: Added tests for unescape_entities.

Also fixed a py3 incompatibility. Thanks to brutasse for the report. Backport of 3754f4a from master.
django · Sep 27, 2013 · 15bdc85 · 15bdc85
1 parent f621aba
commit 15bdc85
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/django/utils/text.py b/django/utils/text.py
@@ -365,12 +365,12 @@ def _replace_entity(match):
                 c = int(text[1:], 16)
             else:
                 c = int(text)
-            return unichr(c)
+            return six.unichr(c)
         except ValueError:
             return match.group(0)
     else:
         try:
-            return unichr(html_entities.name2codepoint[text])
+            return six.unichr(html_entities.name2codepoint[text])
         except (ValueError, KeyError):
             return match.group(0)
 

diff --git a/tests/utils_tests/test_text.py b/tests/utils_tests/test_text.py
@@ -106,3 +106,16 @@ def test_slugify(self):
         )
         for value, output in items:
             self.assertEqual(text.slugify(value), output)
+
+    def test_unescape_entities(self):
+        items = [
+            ('', ''),
+            ('foo', 'foo'),
+            ('&amp;', '&'),
+            ('&#x26;', '&'),
+            ('&#38;', '&'),
+            ('foo &amp; bar', 'foo & bar'),
+            ('foo & bar', 'foo & bar'),
+        ]
+        for value, output in items:
+            self.assertEqual(text.unescape_entities(value), output)