Skip to content

Commit

Permalink
Fixed #22447 -- Make sure custom model bases can be migrated.
Browse files Browse the repository at this point in the history
Thanks to cdestigter for the report.
  • Loading branch information
charettes committed Apr 29, 2014
1 parent a2340ac commit 390f888
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
9 changes: 9 additions & 0 deletions tests/migrations/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,18 @@

from django.apps.registry import Apps
from django.db import models
from django.utils import six
from django.utils.encoding import python_2_unicode_compatible


class CustomModelBase(models.base.ModelBase):
pass


class ModelWithCustomBase(six.with_metaclass(CustomModelBase, models.Model)):
pass


@python_2_unicode_compatible
class UnicodeModel(models.Model):
title = models.CharField('ÚÑÍ¢ÓÐÉ', max_length=20, default='“Ðjáñgó”')
Expand Down
8 changes: 8 additions & 0 deletions tests/migrations/test_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
from django.db.migrations.state import ProjectState, ModelState, InvalidBasesError
from django.test import TestCase

from .models import ModelWithCustomBase


class StateTests(TestCase):
"""
Expand Down Expand Up @@ -335,3 +337,9 @@ class Meta:
project_state.add_model_state(ModelState.from_model(Magazine))
with self.assertRaises(ValueError):
rendered_state = project_state.render()


class ModelStateTests(TestCase):
def test_custom_model_base(self):
state = ModelState.from_model(ModelWithCustomBase)
self.assertEqual(state.bases, (models.Model,))

0 comments on commit 390f888

Please sign in to comment.