Fixed #20321 -- Added missing key name in MergeDict KeyError message

Thanks mark.harviston et gmail.com for the report.
django · Apr 26, 2013 · 4769db6 · 4769db6
1 parent 6bccbc0
commit 4769db6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/django/utils/datastructures.py b/django/utils/datastructures.py
@@ -26,7 +26,7 @@ def __getitem__(self, key):
                 return dict_[key]
             except KeyError:
                 pass
-        raise KeyError
+        raise KeyError(key)
 
     def __copy__(self):
         return self.__class__(*self.dicts)

diff --git a/tests/utils_tests/test_datastructures.py b/tests/utils_tests/test_datastructures.py
@@ -209,6 +209,14 @@ def test_bool_casting(self):
         self.assertFalse(empty)
         self.assertTrue(not_empty)
 
+    def test_key_error(self):
+        """
+        Test that the message of KeyError contains the missing key name.
+        """
+        d1 = MergeDict({'key1': 42})
+        with six.assertRaisesRegex(self, KeyError, 'key2'):
+            d1['key2']
+
 
 class MultiValueDictTests(SimpleTestCase):