Skip to content

Commit

Permalink
Fixed #4338 -- Added pop() method to SessionWrapper. Thanks, Gary Wil…
Browse files Browse the repository at this point in the history
…son.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@5306 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
malcolmt committed May 21, 2007
1 parent fd21702 commit 4c53116
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
3 changes: 3 additions & 0 deletions django/contrib/sessions/middleware.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ def items(self):
def get(self, key, default=None): def get(self, key, default=None):
return self._session.get(key, default) return self._session.get(key, default)


def pop(self, key, *args):
return self._session.pop(key, *args)

def set_test_cookie(self): def set_test_cookie(self):
self[TEST_COOKIE_NAME] = TEST_COOKIE_VALUE self[TEST_COOKIE_NAME] = TEST_COOKIE_VALUE


Expand Down
19 changes: 19 additions & 0 deletions django/contrib/sessions/tests.py
Original file line number Original file line Diff line number Diff line change
@@ -0,0 +1,19 @@
r"""
>>> s = SessionWrapper(None)
Inject data into the session cache.
>>> s._session_cache = {}
>>> s._session_cache['some key'] = 'exists'
>>> s.pop('some key')
'exists'
>>> s.pop('some key', 'does not exist')
'does not exist'
"""

from django.contrib.sessions.middleware import SessionWrapper

if __name__ == '__main__':
import doctest
doctest.testmod()

0 comments on commit 4c53116

Please sign in to comment.